-
Notifications
You must be signed in to change notification settings - Fork 621
explorer: add support for IDA 9.2 #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
explorer: add support for IDA 9.2 #2723
Conversation
Introduce a new module `qt_compat.py` providing a unified import interface and API compatibility for Qt modules. It handles differences between PyQt5 (used in IDA <9.2) and PySide6 (used in IDA >=9.2). Update all plugin modules to import Qt components via this compatibility layer instead of directly importing from PyQt5. This enhances plugin compatibility across different IDA versions. Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
Apply isort with --length-sort flag to maintain consistency with project standards. Reorder imports in all modified IDA plugin files.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Remove unnecessary f-string prefixes and fix implicit string concatenation to satisfy ruff F541 and NIC002 checks.
ah, right, i'll reopen from my personal account, sorry |
Add PySide6 to deptry's known_first_party list to recognize it as an external dependency provided by IDA runtime environment (similar to PyQt5). This resolves DEP001 warnings in qt_compat.py.
Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
I'm testing this now. Feel free to reopen in the meantime. |
Should this work with or without the PYQT5 shim or both? |
Without the shims I get:
With the shims:
|
"netnode", | ||
"PyQt5" | ||
"PyQt5", | ||
"PySide6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should bump ida-settings>=3.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, ida-settings has some breaking changes that won't work here yet. so we need to pin to less than 3
attempt to close #2707
at the moment, this is completely vibe coded. i'll confirm it works locally in a moment.