Skip to content

Added match to header jwk evaluate_for predicate impl #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added match to header jwk evaluate_for predicate impl #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions fcrates/dpop/src/proof/header/jwk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,24 @@ mod predicate {
/// JWK Contains a private key.
#[error("JWK Contains a private key.")]
ContainsPrivateKey,
/// JWK is using an unsupported key type (oct)
/// Unsupported by underlying picky::jose::jwk crate
#[error("JWK is using an unsupported key type.")]
UsingUnsupportedKeyType,
}

impl<K: Borrow<Jwk>> SyncEvaluablePredicate<K> for IsValidDPoPProofJwk {
type EvalError = InvalidDPoPProofJwk;

fn evaluate_for(_jwk: &K) -> Result<(), Self::EvalError> {
fn evaluate_for(jwk: &K) -> Result<(), Self::EvalError> {
// TODO. Filter out any private keys.
Ok(())
let borrow_jwk: &Jwk = jwk.borrow();
match borrow_jwk.key {
picky::jose::jwk::JwkKeyType::Ed(_) => Ok(()),
picky::jose::jwk::JwkKeyType::Ec(_) => Ok(()),
picky::jose::jwk::JwkKeyType::Rsa(_) => Ok(()),
picky::jose::jwk::JwkKeyType::Oct => Err(InvalidDPoPProofJwk::UsingUnsupportedKeyType),
}
}
}

Expand Down