Skip to content

breaking change: make it clearer when a disabled switch is already checked #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

breaking change: make it clearer when a disabled switch is already checked #8002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1661116
differentiate disabled switch when checked
jgravois Jun 23, 2025
7dce36e
prettier
jgravois Jun 23, 2025
22679a6
:nail_care:
jgravois Jun 26, 2025
bfbea94
Merge remote-tracking branch 'upstream/master' into switch-checked-di…
jgravois Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/@mantine/core/src/components/Switch/Switch.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@
--switch-cursor: not-allowed;
}

.input:checked:disabled + &,
.input:checked[data-disabled] + & {
--switch-bg: var(--switch-color);
opacity: 0.35;
}

@mixin light {
--switch-bg: var(--mantine-color-gray-3);
--switch-text-color: var(--mantine-color-gray-6);
Expand Down
2 changes: 2 additions & 0 deletions packages/@mantine/core/src/components/Switch/Switch.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export function WithinDisabledFieldset() {
<legend>Disabled fieldset</legend>
<Switch label="Disabled by fieldset" />
<Switch label="Disabled by prop" disabled mt="md" />
<Switch label="Disabled by fieldset (checked)" checked mt="md" />
<Switch label="Disabled by prop (checked)" checked disabled mt="md" />
</fieldset>
);
}
Expand Down