Prototyping React #4
Conversation
Signed-off-by: Victor Boctor <[email protected]>
Signed-off-by: Victor Boctor <[email protected]>
Signed-off-by: Victor Boctor <[email protected]>
Signed-off-by: Victor Boctor <[email protected]>
It is much simpler to have the two arguments directly on the function. Signed-off-by: Victor Boctor <[email protected]>
- Removed the ConfigService from JS - Added calls to LocalizedStringsGetCommand() as sample and embedded the result html for JS. - Added calls to ConfigsGetCommand() as samlpe and embedded the result in html for JS. Signed-off-by: Victor Boctor <[email protected]>
| export interface Relationship { | ||
| id: number; | ||
| type: RelationshipType; | ||
| issue: Issue; |
There was a problem hiding this comment.
@waltergar The relationship should use the proper Issue, but it can use IssueRelationshipRef or equivalent. This way the proper Issue model could enforce the right semantics, e.g. fields like description and project are mandatory. It also is strange to have an issue that contains a relationship that contains an issue.
| </select> | ||
| | ||
| <input | ||
| type='text' |
There was a problem hiding this comment.
@waltergar Typing the issue id and then pressing Enter, no longer works.
There was a problem hiding this comment.
@vboctor why not? I think it's working properly
| <button | ||
| onClick={() => this.handleRelationshipAdd()} | ||
| className='btn btn-primary btn-sm btn-white btn-round' | ||
| >Add</button> |
There was a problem hiding this comment.
@waltergar Replace all hard-coded strings with localized one that are now available in the html div that I added.
config_defaults_inc.php
Outdated
| * Default Bug dependent | ||
| * @global integer $g_default_bug_dependant | ||
| */ | ||
| $g_default_bug_dependant = BUG_DEPENDANT; |
There was a problem hiding this comment.
@waltergar There should be no need for us to add config options since we are trying to have parity with the existing system that didn't need such config.
Signed-off-by: Victor Boctor <[email protected]>
Supply the auto-complete candidates from the last visited issue list.
vboctor
force-pushed
the
react-relationships
branch
from
59cdef6 to
883968a
Compare
…hub.com:mantishub/mantisbt into react-relationships # Conflicts: # client/js/components/IssueRelationships.tsx
| try { | ||
| const relationships = await this.Service.RelationshipAdd(this.state.reqRelTyp, parseInt(issueId)); | ||
| this.setState({ relationships }); | ||
| toast.success('Success!'); |
There was a problem hiding this comment.
You can use localized string operation_successful for this.
| this.setState({ relationships }); | ||
| } catch (error) { | ||
|
|
||
| toast.success('Success!'); |
There was a problem hiding this comment.
Use localized string operation_successful.
client/js/services/IssueService.ts
Outdated
| throw new Error(e.response.data.message); | ||
| else | ||
| throw new Error(e); | ||
| throw e; |
There was a problem hiding this comment.
Why catch the exception just to throw it again? I would just remove the try/catch from both this add/delete methods for relationships.
2 participants
No description provided.