Implement changes as requested for pull request, bring up-to-date #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add CI script * fix linting * add comment about tests * lint all files in src folder * also build typescript for all commits * fix typescript errors * cleanup * fix root page slug bug in parent input * Fix typo in build lint test yml * Remove commented code * Run build last in gha --------- Co-authored-by: djohalo2 <[email protected]>
adds check for language
Bring up-to-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should resolve the feedback on Q42#36 and also brings it up to date.
The important changes are:
I know you submitted this while on holiday, so I hope this can help. I also hope that I resolved the differences correctly!
All the best, thank you for this branch.