Skip to content

Backwards and shift-arrow navigation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

radiohacktive
Copy link
Contributor

Directory permissions cease the screen from populating each area, so there is not yet a conflict with that future implementation. My keyboard (HP netbook) also doesn't have PageUp/PageDown, so I was looking at holding down shift to do the same thing. Let me know what you think.

@matejc
Copy link
Owner

matejc commented Jan 8, 2014

Backwards navigation:
lets say, we run tarman in /home/matej/workarea/tarman_synd/ directory.. and we select README.rst, then creates NewArchive.tar.gz right there, and reopen the tarman and select that archive and go to the deepest file which in this case is this README.rst and now we are here: /home/matej/workarea/tarman_synd/NewArchive.tar.gz/home/matej/workarea/tarman_synd

This is meant to work like that, by running tarman in some directory, you make it so-called the root of archive.

Maybe you could solve this .. by scanning the checked files on creation of archive and dynamically set the root to the highest file located in directory tree, i.e.: you have 2 files selected.. /home/matej/a/b/c/file1 and /home/matej/a/file2 then root can be set dynamically to the /home/matej/a and in archive you will have paths: b/c/file1 and file2. But I guess... this produces more problems than it solves, 1. user will not expect this and 2. there will be no way to set the root inside archive.

@matejc
Copy link
Owner

matejc commented Jan 8, 2014

Shift+<arrow> is used for selecting files - generally in file browsers.

For keyboard keys you can look into ncdu curses application - http://dev.yorhel.nl/ncdu

@matejc
Copy link
Owner

matejc commented Jan 8, 2014

Thanks for the try! :)
And please do not take this personal, I am not enjoying turning down any contributions.

@radiohacktive
Copy link
Contributor Author

No worries at all, again this is just messing around with improvements for me :)

So if I understand correctly, there is a predefined "root_directory" which is being used to satisfy two functions: one to cease further parent directory changing, and one as a working directory in which to contstruct the tar file. My intention was to apply the change to the former; therefore, what if we have separate variables for each function?

I'll take a look at the keyboard shortcuts, I would like to add at least one more pair.

Thanks for looking into it!

@matejc
Copy link
Owner

matejc commented Jan 9, 2014

One root directory is there for a reason, if you have /a/b/c/d/file2 and /a/b/file1 files and you run cd /a/b/c; tarman, your root for the archive will be /a/b/c and what is the use of going up if we can not archive file1 in the first place, because of root being /a/b/c?

@radiohacktive
Copy link
Contributor Author

One "root_directory" would be dynamically changing depending on the screen to which the user navigates and initiates a tar file creation (latter from my previous comment), and one (ideally the unit root directory '/') would simply be to allow the user to navigate to some parent directory. This grants the user the ability to create a tar file in any directory without the strict requirement be made that the tar-initiating-directory in question is some subdirectory of the path argument or $HOME (no path argument).

@matejc
Copy link
Owner

matejc commented Jan 9, 2014

OK, you have a green light from me, but do not waste too much time on this, this application is meant to be for quick archive management therefore is quite ok if user quits and reopens tarman on other location, but I agree this would be a nice little feature.

@matejc
Copy link
Owner

matejc commented Jan 9, 2014

going to sleep now, I should be available in about 10 hours from now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants