Skip to content

Fix registerTex() to handle tex.packages that is already an array #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 30, 2025

This PR fixes the component utility that marks preloaded TeX packages so that it will properly merge the new packages into the existing package list if the old list was an array (rather than {'[+]': [...]}).

@dpvc dpvc requested a review from zorkow July 30, 2025 18:00
@dpvc dpvc added this to the v4.0 milestone Jul 30, 2025
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.71%. Comparing base (e68c42f) to head (c2675cf).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1323   +/-   ##
========================================
  Coverage    86.71%   86.71%           
========================================
  Files          337      337           
  Lines        84074    84077    +3     
  Branches      4758     4758           
========================================
+ Hits         72904    72907    +3     
+ Misses       11170    11147   -23     
- Partials         0       23   +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 34b1421 into develop Aug 1, 2025
3 checks passed
@dpvc dpvc deleted the fix/registerTex branch August 1, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants