Add yaw in GPS fact #13019
Open
Add yaw in GPS fact #13019
+152
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The toolbar indicator dropdown isn't meant to include stuff like this. It's for general status. This is a pretty low level detail. With the yaw adding to the fact group you can just include the values you want in the instrument panel to view. |
Louis-max-H
changed the title
|
Thanks for the review !
|
|
I like it. What about GPS_RAW_INT? We should include the yaw from that message as well. I'm not sure we can assume that the RTK Rover is always GPS2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add yaw in GPS fact and displayed it under GPS Status menu
Description
When using GPS heading along Gyroscope, QGrondControl will only show gyroscope compass, user can't know easily if heading is working correctly or what is his value.
I have added yaw to gps fact and make it displayed under Vehicle GPS Status menu.
The only way before was to open MAVLink inspector and check the value of yaw.
0 will be displayed if GPS do not provide heading and N/A when heading is not available.
Test Steps
Use GPS heading,
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.