WIP #731: Build images for linux/amd64 and linux/arm64 #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow action on push to main and issue-731 branches
- Refactor docker-login-action from Docker-based to composite to support step usage - Update docker-build.yml to provide DOCKERHUB_USERNAME and DOCKERHUB_TOKEN secrets to the login action
All matrix jobs to continue regardless of outcome
Using image_name without the inputs
- Trigger workflow on version tags matching 'v*' - Introduce `version` job to extract semantic version components (major, minor, full) - Make `build` job depend on `version` and pass version metadata to build-action - Enable multi-version tagging support (vX.Y.Z, vX.Y, vX) for Docker images
- Removed the separate 'version' job in favor of an inline step in the 'build' job - Version info is now extracted directly from the tag if available, or defaults to 0.5.2 - Simplifies workflow structure while maintaining version tagging behavior
… the loop — those expressions are only parsed by GitHub Actions outside the script block. Inside the run: | block (a Bash script), they become plain text strings.
…ix support - Remove hardcoded version inputs from build-action - Add automatic extraction of commit ID and version from GITHUB_REF - Tag rolling images with rolling-YYYYmmDD format - Extend build matrix to support multiple alpine_version and image types (core, web, postorius) - Consolidate build steps into a single matrix-based loop for clarity and maintainability
- Removed `platform` as an input from the `build-action` composite action. - Updated `docker buildx build` to use multi-arch build for `linux/amd64,linux/arm64` by default. - Simplified version fallback logic in `action.yml`. - Updated `docker-build.yml` workflow to drop matrix strategy for platform and removed related references.
- Added `ARG ALPINE_VERSION` and updated `FROM` directives in Dockerfiles (core, postorius, web) to use it - Extended GitHub Actions matrix to include general `3` tag alongside specific versions (3.20, 3.21, 3.21.3) - Retained previous `FROM alpine:x` lines as comments for reference
…bers, and 3.20 is the same as 3.2 in float notation.
|
That's for this, I've been meaning to move other Github CI but haven't had bandwidth to make the change. The exiting CI flow tests images by starting them up. See https://github.com/maxking/docker-mailman/blob/main/tests/test.sh. We would need to do that before we upload built images. Also, does the parameterized version of alpine allow for dependabot to update them? If not, let's keep the existing one since I'd like to have automated PRs upgrading base OS and packages. Finally, Dockerfile.dev is used for rolling images only. Dockerfile is used when a tag is pushed so we can cut stable releases from the tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand Circle CI is the CI of choice. I did not have a Circle CI account. I know little about Circle CI. I could not get the Circle CI changes from #731 to work. Tried to build an ARM image with Circle CI and failed.
Looks like PR #741 was closed with unmerged commits? And I do not see any ARM images on DockerHub.
This PR adds a GitHub workflow that will create docker images for
For
using
I think that covers all the base images I saw in the FROM in the Dockerfiles.
This GitHub strategy matrix creates 12 docker images, they can be viewed at My Hub.
Looking at the build.sh only the
Dockerfile.devis used?I followed the variable naming conventions.
You can change the
TAG_NSin .github/workflows/docker-build.ymlalpine_versionin .github/workflows/docker-build.ymlplatformsin .github/actions/build-action/action.yml