Skip to content

Updated comments in README.md #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated comments in README.md #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestIntegrationExample(t *testing.T) {

var err error
// Initializing CITF without config file.
// Also We should not include K8S as currently we don't have kubernetes environment setup
// Also we should not include K8S, as currently we don't have kubernetes environment setup.
CitfInstance, err = citf.NewCITF(citfoptions.CreateOptionsIncludeAllButK8s(""))
Expect(err).NotTo(HaveOccurred())

Expand All @@ -125,28 +125,28 @@ func TestIntegrationExample(t *testing.T) {

var _ = BeforeSuite(func() {

// Setting up the default Platform i.e minikube
// Setting up the default platform i.e minikube.
err := CitfInstance.Environment.Setup()
Expect(err).NotTo(HaveOccurred())

// You have to update the K8s config when environment has been set up
// this extra step will be unsolicited in upcoming changes.
// You have to update the K8s config when environment has been set up.
// This extra step will be unsolicited in upcoming changes.
err = CitfInstance.Reload(citfoptions.CreateOptionsIncludeAll(""))
Expect(err).NotTo(HaveOccurred())

// Wait until platform is up
// Wait until platform is up.
time.Sleep(30 * time.Second)

err = CitfInstance.K8S.YAMLApply("./nginx-rc.yaml")
Expect(err).NotTo(HaveOccurred())

// Wait until the pod is up and running
// Wait until the pod is up and running.
time.Sleep(30 * time.Second)
})

var _ = AfterSuite(func() {

// Tear Down the Platform
// Tear Down the Platform.
err := CitfInstance.Environment.Teardown()
Expect(err).NotTo(HaveOccurred())
})
Expand All @@ -157,10 +157,10 @@ var _ = Describe("Integration Test", func() {
pods, err := CitfInstance.K8S.GetPods("default", "nginx")
Expect(err).NotTo(HaveOccurred())

// Give pods some time to generate logs
// Give pods some time to generate logs.
time.Sleep(2 * time.Second)

// Assuming that only 1 nginx pod is running
// Assuming that only 1 nginx pod is running.
for _, v := range pods {
log, err := CitfInstance.K8S.GetLog(v.GetName(), "default")
Expect(err).NotTo(HaveOccurred())
Expand Down