Skip to content

Add v3.5 smoke tests #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add v3.5 smoke tests #643

wants to merge 8 commits into from

Conversation

gitbuda
Copy link
Member

@gitbuda gitbuda commented Jul 20, 2025 •
edited
Loading

TODOs

  • Test the HA upgrade scenario, interesting details under (test entities that should be preserved across any upgrade) https://memgraph.slack.com/archives/CS5827FK3/p1743138541518649
  • Try testing Kafka and Pulsar (streams) somehow
  • Test Docker compose
  • Test total execution time
  • Test query modules better:
    • Run a/all procedures from all query modules to make sure they are all working, because of cases like Move memgraph user's home directory #594, OR make sure all C/C++/Python/Rust dependencies can be loaded
    • Figure out the module count because that always fails

#607 << PREV

@gitbuda gitbuda mentioned this pull request Jul 20, 2025
Merged
10 tasks
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2025
@gitbuda @antejavor
Add v3.4 smoke tests and basic HA cluster upgrade test (#607)
de021ef 
The main challenge with the HA cluster upgrade tests is that there are
multiple different things to wait for (helm, port-forward,
data/coordinator getting ready) -> it gets very complex very quickly.

## v3.4
- [x] Nested indices
- [x] Vector search on edges
- [x] Implement the k8s helm chart upgrade scenario
- [x] Resolve memgraph/memgraph#3023 (any
reuse of the PVCs failed)
- [x] memgraph/best-practices#43 -> almost
exactly the same, look at how the script is waiting for pods
- [x] Make upgrades more robust ->
https://www.notion.so/memgraph/How-to-make-upgrade-more-robust-1c26b158b98180a1a76cd8998e2e7ca4#1c36b158b98180f286d4eed383d1451a
- [x] Add some other feature tests (expand test cases) -> skipped
- [x] Put a timeout to the wait_for_memgraph function (default is 10s)
- [x] Validate results / make sure to exit on errors / properly name /
refactor Python scripts
- [x] Test for if main is elected specifically before running any CREATE
query on the cluster

NEXT >> #643

---------

Co-authored-by: antejavor <[email protected]>
gitbuda
gitbuda commented Aug 17, 2025
View reviewed changes
gitbuda
gitbuda commented Aug 17, 2025
View reviewed changes
gitbuda
gitbuda commented Aug 17, 2025
View reviewed changes
smoke-release-testing/mgconsole/query_modules.bash
@@ -8,7 +8,7 @@ test_query_modules() {
echo "FEATURE: All MAGE query modules"

# TODO(gitbuda): What are the 3 added modules? -> Probably the migration modules.
echo "CALL mg.procedures() YIELD * RETURN count(*) AS cnt;" | $MEMGRAPH_CONSOLE_BINARY --host $__host --port $__port --output-format=csv | python3 $SCRIPT_DIR/validator.py first_as_int -f cnt -e 312
echo "CALL mg.procedures() YIELD * RETURN count(*) AS cnt;" | $MEMGRAPH_CONSOLE_BINARY --host $__host --port $__port --output-format=csv | python3 $SCRIPT_DIR/validator.py first_as_int -f cnt -e 313
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Make this more robust across testing different versions.

gitbuda
gitbuda commented Aug 17, 2025
View reviewed changes
smoke-release-testing/experiment.bash
@@ -5,13 +5,13 @@ source "$SCRIPT_DIR/utils.bash"
# NOTE: Use the below line if you just want to spin up the containers and leave them running.
# run_memgraph_docker_containers RC RC
# NOTE: Use the below line if you want to cleanup the containers after run of this script.
spinup_and_cleanup_memgraph_dockers none none
spinup_and_cleanup_memgraph_dockers Dockerhub RC
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Revert

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gitbuda