Test: finish enzyme removal #1809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
force-pushed
the
test/finish-enzyme-migration
branch
from
daa3c9e to
0eb51f8
Compare
samuelreichert
force-pushed
the
test/finish-enzyme-migration
branch
from
0eb51f8 to
aa5ad01
Compare
r0b1n
reviewed
Aug 6, 2025
Comment on lines
+2
to
+7
| // Removed unused Alert, AlertProps imports | ||
| import { actionValue, EditableValueBuilder } from "@mendix/widget-plugin-test-utils"; | ||
| import { mount, ReactWrapper } from "enzyme"; | ||
| import { render, fireEvent } from "@testing-library/react"; | ||
| import { createElement } from "react"; | ||
|
|
||
| import SwitchComponent, { SwitchProps } from "../components/Switch"; | ||
| // Removed unused SwitchComponent, SwitchProps imports |
r0b1n
reviewed
Aug 6, 2025
| it("handles keydown events", async () => { | ||
| // NOTE: jsdom does not reliably trigger keyboard events for custom sliders. | ||
| // fireEvent is used for clarity, but may not trigger the slider's internal logic in jsdom. |
There was a problem hiding this comment.
Can it be done with userEvent module which seems to emulate is better than fireEvent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
No code changes (changes to documentation, CI, metadata, etc.)
Refactoring (e.g. file rename, variable rename, etc.)
est related change (New E2E test, test automation, etc.)
Finishing the removal of enzyme from all pluggable widgets