Skip to content

Feature 4326 intellij plugin mark false positive #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 5, 2025
Merged

Feature 4326 intellij plugin mark false positive #4343

merged 10 commits into from
Aug 5, 2025

Conversation

@hamidonos
Copy link
Collaborator

hamidonos added 8 commits July 18, 2025 15:17
@hamidonos
implement version 1.0.0 of intellij plugin #4273
4d9fcb9
@hamidonos
pr fixes
a2c0812
@hamidonos
force settings when settings are not set
daeb120
@hamidonos
force settings when settings are not set
63535ee
@hamidonos
handling ui updates in async fahion
31f9838
@hamidonos
implement mark false positive in intellij plugin #4326
f90f36e
@hamidonos
tests
b988512
@hamidonos
Merge branch 'develop' into feature-4326-intellij-plugin-mark-false-p…
83cbc0b 
…ositive

# Conflicts:
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/SecHubReportRequestListener.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/SecHubSettingsDialogListener.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/action/SechubResetReportAction.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/sechubaccess/NoOpSecHubAccessClient.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/sechubaccess/SecHubAccess.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/sechubaccess/SecHubAccessClient.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/window/SecHubReportTabSwitcher.java
#	ide-plugins/jetbrains/src/main/java-intellij/com/mercedesbenz/sechub/plugin/idea/window/SecHubServerPanel.java
#	ide-plugins/jetbrains/src/test/java/com/mercedesbenz/sechub/plugin/idea/sechubaccess/SecHubAccessClientTest.java
#	ide-plugins/jetbrains/src/test/java/com/mercedesbenz/sechub/settings/SecHubSettingsComponentTest.java
#	ide-plugins/jetbrains/src/test/java/com/mercedesbenz/sechub/settings/SecHubSettingsConfigurableTest.java
@hamidonos hamidonos requested a review from lorriborri August 4, 2025 10:15
lorriborri
lorriborri requested changes Aug 4, 2025
View reviewed changes
Copy link
Member

@lorriborri lorriborri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Good Work! ⭐
I've reviewed your code and found some issues and a bug, please have a look at my comments. :)

I think you can also remove:

  • the JTreeUtil class
  • the getIconForTrafficLight method

@lorriborri lorriborri self-requested a review August 5, 2025 11:06
lorriborri
lorriborri approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@lorriborri lorriborri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good to me! ⭐ 🦥
Lets merge!

@hamidonos hamidonos merged commit 2985601 into develop Aug 5, 2025
2 checks passed
@hamidonos hamidonos deleted the feature-4326-intellij-plugin-mark-false-positive branch August 5, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorriborri lorriborri lorriborri approved these changes

Assignees

@lorriborri lorriborri

@hamidonos hamidonos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark false positives in IntelliJ Plugin

3 participants

@hamidonos @lorriborri