Skip to content

Add timeouts to get_ringtone and get_canned_messages #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdxlocations
Copy link
Member

When firmware is built without these modules these requests just hang. This PR adds a 2 second delay before moving on.

@ianmcorvidae
Copy link
Contributor

Seems reasonable enough for now to get things working again for those cases. A 2s limits feels like it'd be a bit low for doing this over remote admin is my main concern. Would it be possible to move this handling into the export-config part, rather than within the node.py functions? A timeout isn't really a big deal with the individual commands the way it is with export, so I think it'd be fine if only that side has the extra handling.

@pdxlocations
Copy link
Member Author

A timeout isn't really a big deal with the individual commands the way it is with export, so I think it'd be fine if only that side has the extra handling.

In my (limited) testing --get-ringtone and --get-canned-messages would just hang with no indication of what was going on if the modules aren't installed, so maybe it's useful to keep the timeout and log message in node?

I've not tested with remote admin at all. What do you think a good delay before timeout would be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants