-
Notifications
You must be signed in to change notification settings - Fork 58
Add tracing sqlite db file support so we can connect from python #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjipelletier
wants to merge
2
commits into
meta-pytorch:main
Choose a base branch
from
benjipelletier:export-D79761474
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+662
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D79761474 |
76314c5
to
ed913d6
Compare
benjipelletier
added a commit
to benjipelletier/monarch-1
that referenced
this pull request
Aug 12, 2025
…a-pytorch#807) Summary: POC of Rust-create sqlite db accessable from native python sqlite connection. This allows us to write python tests that test Monarch and assert user (or BE) events using sql queries. * Uses reloadable layer to inject SqliteLayer into tracing registry on demand. * Exposes `with_tracing_db_file` to python to create and get the DB file name so we can connect to Differential Revision: D79761474
This pull request was exported from Phabricator. Differential Revision: D79761474 |
benjipelletier
added a commit
to benjipelletier/monarch-1
that referenced
this pull request
Aug 14, 2025
…a-pytorch#807) Summary: POC of Rust-create sqlite db accessable from native python sqlite connection. This allows us to write python tests that test Monarch and assert user (or BE) events using sql queries. * Uses reloadable layer to inject SqliteLayer into tracing registry on demand. * Exposes `with_tracing_db_file` to python to create and get the DB file name so we can connect to Reviewed By: eliothedeman, pablorfb-meta Differential Revision: D79761474
ed913d6
to
bf599f2
Compare
This pull request was exported from Phabricator. Differential Revision: D79761474 |
Summary: New tracer subscriber to be used for testing (e.g., script or simulator) 1. New logging layer for use in tests that writes all log messages to a series of sqlite tables 2. Add capability to do sql based assertions for script tests or simulation tests 3. New trace level logging events on actor lifecycle events Next diffs will: * Get this working for our PAFT simulator tests so we can easily assert * Support custom columns Reviewed By: eliothedeman Differential Revision: D73512355
…a-pytorch#807) Summary: POC of Rust-create sqlite db accessable from native python sqlite connection. This allows us to write python tests that test Monarch and assert user (or BE) events using sql queries. * Uses reloadable layer to inject SqliteLayer into tracing registry on demand. * Exposes `with_tracing_db_file` to python to create and get the DB file name so we can connect to Reviewed By: eliothedeman, pablorfb-meta Differential Revision: D79761474
bf599f2
to
8936a0e
Compare
This pull request was exported from Phabricator. Differential Revision: D79761474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
POC of Rust-create sqlite db accessable from native python sqlite connection. This allows us to write python tests that test Monarch and assert user (or BE) events using sql queries.
with_tracing_db_file
to python to create and get the DB file name so we can connect toDifferential Revision: D79761474