Skip to content

Use tokio::oneshot for sim clock #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use tokio::oneshot for sim clock #822

wants to merge 2 commits into from
+125 −151

Conversation

thomasywang
Copy link
Contributor

Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80029571

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80029571

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80029571

thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 14, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
cfb5c5f 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 14, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
311e90d 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 14, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
d513c94 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 14, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
d061177 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 14, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
2b4a263 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80029571

thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 14, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
fe03ff0 
Summary:
Pull Request resolved: meta-pytorch#822

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 18, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
c15579e 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 19, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
41fe678 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 19, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
d74605d 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 19, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
bc11cb6 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 19, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
aa14bba 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80029571

thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 19, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
dcb87a1 
Summary:
Pull Request resolved: meta-pytorch#822

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Differential Revision: D80029571
@thomasywang @facebook-github-bot
Use tokio::time::Duration and tokio::time::Instant for timekeeping
d524452 
Summary: Previously we had to use u64 for serialization reasons but those reasons no longer exist

Differential Revision: D80556690
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 20, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
00cb8a6 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Reviewed By: pablorfb-meta

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 20, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
8a473c7 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Reviewed By: pablorfb-meta

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 20, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
4a05b1f 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Reviewed By: pablorfb-meta

Differential Revision: D80029571
thomasywang added a commit to thomasywang/monarch-1 that referenced this pull request Aug 20, 2025
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
b3fffe6 
Summary:

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Reviewed By: pablorfb-meta

Differential Revision: D80029571
@thomasywang @facebook-github-bot
Use tokio::oneshot for sim clock (meta-pytorch#822)
3d127e1 
Summary:
Pull Request resolved: meta-pytorch#822

There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine

Reviewed By: pablorfb-meta

Differential Revision: D80029571
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80029571

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fb85445.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasywang @facebook-github-bot