Compute resource aware simulation #857
Closed
+189
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80137963 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Differential Revision: D80137963
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Differential Revision: D80137963
thomasywang
force-pushed
the
export-D80137963
branch
from
918d495 to
516fa0e
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Differential Revision: D80137963
|
This pull request was exported from Phabricator. Differential Revision: D80137963 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: Pull Request resolved: meta-pytorch#857 The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Differential Revision: D80137963
thomasywang
force-pushed
the
export-D80137963
branch
from
516fa0e to
f4665e7
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
thomasywang
force-pushed
the
export-D80137963
branch
from
f4665e7 to
4711832
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
|
This pull request was exported from Phabricator. Differential Revision: D80137963 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: Pull Request resolved: meta-pytorch#857 The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
thomasywang
force-pushed
the
export-D80137963
branch
from
4711832 to
6f0e589
Compare
Summary: Previously we had to use u64 for serialization reasons but those reasons no longer exist Differential Revision: D80556690
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
Summary: Pull Request resolved: meta-pytorch#854 When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965 Reviewed By: pablorfb-meta
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 20, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
thomasywang
force-pushed
the
export-D80137963
branch
from
6f0e589 to
e830cf1
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 20, 2025
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
Summary: Pull Request resolved: meta-pytorch#857 The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet. Reviewed By: pablorfb-meta Differential Revision: D80137963
|
This pull request was exported from Phabricator. Differential Revision: D80137963 |
thomasywang
force-pushed
the
export-D80137963
branch
from
e830cf1 to
d547802
Compare
|
This pull request has been merged in 7238c13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The sim allocator will now register the location (region, dc, zone, rack, host, gpu) of every ProcId upon creation with the simnet.
Differential Revision: D80137963