Fix input_dist for when it has to handle KVZCH and non-KVZCH tables together for row-wise sharding #3444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
…ogether for row-wise sharding (meta-pytorch#3444) Summary: In the KVZCH scenarios, the input_dist for row-wise sharding will have to deal with KVZCH and non-KVZCH features together. This means that the virtual_table_feature_num_buckets will have to represent non-KVZCH features too. In this diff, we default the value of the num_buckets to world_size for non-KVZCH features. Differential Revision: D84094039
nipung90
added
CLA Signed
nipung90
force-pushed
the
export-D84094039
branch
from
108dbae to
0743ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the KVZCH scenarios, the input_dist for row-wise sharding will have to deal with KVZCH and non-KVZCH features together. This means that the virtual_table_feature_num_buckets will have to represent non-KVZCH features too.
In this diff, we default the value of the num_buckets to world_size for non-KVZCH features.
Differential Revision: D84094039