Fixes/initial fixes

CHANGELOG.md

@@ -0,0 +1,25 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+## [UNRELEASED]
+
+### Fixed
+- Wallet path handling in `config wallets set` and `config wallets add` commands
+  - Added path normalization to store absolute paths instead of relative paths
+  - Added validation to check if wallet file exists before setting it
+  - Fixed issue where changing directories would cause "missing wallet file" errors
+  - Improved error messages for better user feedback
+
+### Changed
+- Updated wallet path storage to use absolute paths consistently
+- Enhanced error handling in wallet configuration commands
+- Improved command index pages with better descriptions and examples
+  - Added detailed descriptions for core commands (asset, collection, plugins)
+  - Enhanced examples with more use cases and options
+  - Improved help text formatting and organization
+  - Added subcommand descriptions and available options
+
+  ## [0.0.6]
+
+  - Initial public beta release

src/commands/config/wallets/add.ts

@@ -1,6 +1,6 @@
 import { Args, Command } from '@oclif/core'
 import fs from 'fs'
-import { dirname } from 'path'
+import { dirname, resolve } from 'path'
 import { createSignerFromPath, getDefaultConfigPath, readConfig } from '../../../lib/Context.js'
 import { ensureDirectoryExists, writeJsonSync } from '../../../lib/file.js'
 import { shortenAddress } from '../../../lib/util.js'
@@ -41,16 +41,19 @@ export default class ConfigWalletAddsCommand extends Command {
       this.error('Path must be a json file')
     }
 
-    // check if the file exists on intial add
-    if (!fs.existsSync(args.path)) {
+    // Normalize the path to be absolute
+    const normalizedPath = resolve(args.path)
+
+    // check if the file exists on initial add
+    if (!fs.existsSync(normalizedPath)) {
       this.error('File does not exist')
     }
 
     const path = flags.config ?? getDefaultConfigPath()
 
     const config = readConfig(path)
 
-    const signer = await createSignerFromPath(args.path)
+    const signer = await createSignerFromPath(normalizedPath)
 
     if (!config.wallets) {
       config.wallets = []
@@ -60,9 +63,9 @@ export default class ConfigWalletAddsCommand extends Command {
         this.error(`Wallet with name ${args.name} already exists`)
       }
 
-      const existingPath = config.wallets.find((wallet) => wallet.path === args.path)
+      const existingPath = config.wallets.find((wallet) => wallet.path === normalizedPath)
       if (existingPath) {
-        this.error(`Wallet with path ${args.path} already exists`)
+        this.error(`Wallet with path ${normalizedPath} already exists`)
       }
 
       const existingAddress = config.wallets.find((wallet) => wallet.address === signer.publicKey.toString())
@@ -74,7 +77,7 @@ export default class ConfigWalletAddsCommand extends Command {
     config.wallets?.push({
       name: args.name,
       address: signer.publicKey,
-      path: args.path,
+      path: normalizedPath,
     })
 
     const dir = dirname(path)

src/commands/config/wallets/new.ts

@@ -1,7 +1,7 @@
 import { generateSigner } from '@metaplex-foundation/umi'
 import { Flags } from '@oclif/core'
 import fs from 'node:fs'
-import { dirname, join, normalize } from 'node:path'
+import { dirname, normalize, resolve } from 'node:path'
 import { BaseCommand } from '../../../BaseCommand.js'
 import { getDefaultConfigPath, readConfig } from '../../../lib/Context.js'
 import { ensureDirectoryExists, writeJsonSync } from '../../../lib/file.js'
@@ -71,7 +71,7 @@ export default class ConfigWalletsNew extends BaseCommand<typeof ConfigWalletsNe
             : `${wallet.publicKey}.json`
 
         // Save wallet file
-        const filePath = join(savePath, fileName)
+        const filePath = resolve(savePath, fileName)
         writeJsonSync(filePath, walletData)
         console.log(`Wallet saved to: ${filePath}`)
 
@@ -104,7 +104,7 @@ export default class ConfigWalletsNew extends BaseCommand<typeof ConfigWalletsNe
 
             const newWallet = {
                 name: flags.name,
-                path: filePath,
+                path: filePath.replace(/\\/g, '\\\\'), // Escape backslashes for JSON
                 address: wallet.publicKey.toString(),
             }
 

src/commands/config/wallets/set.ts

@@ -3,14 +3,14 @@ import {getDefaultConfigPath, readConfig} from '../../../lib/Context.js'
 import walletSelectorPrompt from '../../../prompts/walletSelectPrompt.js'
 import {shortenAddress} from './../../../lib/util.js'
 
-import {dirname} from 'path'
+import {dirname, resolve} from 'path'
 import {ensureDirectoryExists, writeJsonSync} from '../../../lib/file.js'
+import fs from 'fs'
 
 export default class ConfigWalletSetCommand extends Command {
   static override description = 'Set a new active wallet from a list of wallets'
 
   public async run(): Promise<void> {
-
     const {flags, args} = await this.parse(ConfigWalletSetCommand)
 
     const path = flags.config ?? getDefaultConfigPath()
@@ -28,7 +28,16 @@ export default class ConfigWalletSetCommand extends Command {
       publicKey: wallet.address
     })))
 
-    config.keypair = selectedWallet.path
+    // Normalize the path to be absolute
+    const normalizedPath = resolve(selectedWallet.path)
+
+    // Validate the file exists
+    if (!fs.existsSync(normalizedPath)) {
+      this.error(`Wallet file not found at: ${normalizedPath}`)
+      return
+    }
+
+    config.keypair = normalizedPath
 
     const dir = dirname(path)
     ensureDirectoryExists(dir)

src/commands/core/asset/index.ts

@@ -1,18 +1,37 @@
-import { Command } from '@oclif/core'
+import { Command, Flags } from '@oclif/core'
 
 export default class CoreAsset extends Command {
-  static override description = 'MPL Core Asset Module'
+  static override description = `MPL Core Asset Management - Create, update, burn, and fetch digital assets
+
+The asset commands provide functionality for managing individual digital assets on the Solana blockchain using the Metaplex Core protocol.
+
+Available subcommands:
+  create  - Create new assets (with wizard, direct input, or file upload)
+  update  - Update asset metadata (name, URI, image)
+  burn    - Burn assets (single or batch)
+  fetch   - Fetch asset data and metadata`
 
   static override examples = [
-    '<%= config.bin %> <%= command.id %>',
+    '$ mplx core asset create --wizard',
+    '$ mplx core asset create --name "My NFT" --uri "https://example.com/metadata.json"',
+    '$ mplx core asset create --files --image "./my-nft.png" --json "./metadata.json"',
+    '$ mplx core asset update <assetId> --name "Updated Name" --uri "https://example.com/new-metadata.json"',
+    '$ mplx core asset burn <assetId>',
+    '$ mplx core asset fetch <assetId> --download',
   ]
 
   static override flags = {
-
+    help: Flags.help({char: 'h'}),
   }
 
   public async run(): Promise<void> {
     const {args, flags} = await this.parse(CoreAsset)
-
+
+    // Show help by default
+    this.log(CoreAsset.description)
+    this.log('\nExamples:')
+    CoreAsset.examples.forEach(example => {
+      this.log(`  ${example}`)
+    })
   }
 }

src/commands/core/collection/index.ts

@@ -1,18 +1,35 @@
 import {Args, Command, Flags} from '@oclif/core'
 
 export default class CoreCollection extends Command {
-  static override description = 'MPL Core Collection Module'
+  static override description = `MPL Core Collection Management - Create and manage collections of digital assets
+
+The collection commands provide functionality for managing groups of digital assets on the Solana blockchain using the Metaplex Core protocol.
+
+Available subcommands:
+  create   - Create new collections (with wizard, direct input, or file upload)
+  fetch    - Fetch collection data and metadata
+  template - Generate template files for collection metadata and image`
 
   static override examples = [
-    '<%= config.bin %> <%= command.id %>',
+    '$ mplx core collection create --wizard',
+    '$ mplx core collection create --name "My Collection" --uri "https://example.com/metadata.json"',
+    '$ mplx core collection create --files --image "./my-collection.png" --json "./metadata.json"',
+    '$ mplx core collection fetch <collectionId>',
+    '$ mplx core collection template',
   ]
 
   static override flags = {
-
+    help: Flags.help({char: 'h'}),
   }
 
   public async run(): Promise<void> {
     const {args, flags} = await this.parse(CoreCollection)
-
+
+    // Show help by default
+    this.log(CoreCollection.description)
+    this.log('\nExamples:')
+    CoreCollection.examples.forEach(example => {
+      this.log(`  ${example}`)
+    })
   }
 }

src/commands/core/index.ts

@@ -1,18 +1,33 @@
 import {Args, Command, Flags} from '@oclif/core'
 
 export default class Core extends Command {
-  static override description = 'MPL Core Program'
+  static override description = `MPL Core Program - Manage digital assets, collections, and plugins on Solana
+
+The core commands provide functionality for managing Metaplex Core assets, collections, and plugins. These commands allow you to create, modify, and manage digital assets on the Solana blockchain using the Metaplex Core protocol.
+
+Available subcommands:
+  asset     - Manage individual digital assets (create, update, burn, fetch)
+  collection - Manage collections of assets (create, fetch)
+  plugins   - Manage asset and collection plugins (add, remove, generate)`
 
   static override examples = [
-    '<%= config.bin %> <%= command.id %>',
+    '$ mplx core asset create --name "My NFT" --uri "https://example.com/metadata.json"',
+    '$ mplx core collection create --name "My Collection" --uri "https://example.com/collection.json"',
+    '$ mplx core plugins add <assetId> --wizard',
   ]
 
   static override flags = {
-
+    help: Flags.help({char: 'h'}),
   }
 
   public async run(): Promise<void> {
     const {args, flags} = await this.parse(Core)
-
+
+    // Show help by default
+    this.log(Core.description)
+    this.log('\nExamples:')
+    Core.examples.forEach(example => {
+      this.log(`  ${example}`)
+    })
   }
 }

src/commands/core/plugins/index.ts

@@ -1,19 +1,58 @@
-import { Command } from '@oclif/core'
+import { Command, Flags } from '@oclif/core'
 import { BaseCommand } from '../../../BaseCommand.js'
 
 export default class CorePlugins extends BaseCommand<typeof CorePlugins> {
-  static override description = 'MPL Core Plugins Module'
+  static override description = `MPL Core Plugin Management - Add and manage plugins for assets and collections
+
+The plugin commands provide functionality for managing plugins that extend the capabilities of assets and collections on the Solana blockchain.
+
+Available subcommands:
+  add      - Add plugins to assets or collections (with wizard or JSON config)
+  remove   - Remove plugins from assets or collections
+  generate - Generate reusable plugin configuration files for scripting
+
+Available Plugin Types:
+  Common Plugins (Asset & Collection):
+    - Attributes
+    - Royalties
+    - Update Delegate
+    - Permanent Freeze
+    - Permanent Transfer
+    - Permanent Burn
+    - Add Blocker
+    - Immutable Metadata
+    - Autograph
+    - Verified Creators
+
+  Collection-specific Plugins:
+    - Master Edition
+
+  Asset-specific Plugins:
+    - Edition
+    - Freeze Delegate
+    - Burn Delegate
+    - Transfer Delegate`
 
   static override examples = [
-    '<%= config.bin %> <%= command.id %>',
+    '$ mplx core plugins add <assetId> --wizard',
+    '$ mplx core plugins add <assetId> ./plugin.json',
+    '$ mplx core plugins generate --asset',
+    '$ mplx core plugins generate --collection',
+
   ]
 
   static override flags = {
-
+    help: Flags.help({char: 'h'}),
   }
 
   public async run(): Promise<void> {
     const {args, flags} = await this.parse(CorePlugins)
-
+
+    // Show help by default
+    this.log(CorePlugins.description)
+    this.log('\nExamples:')
+    CorePlugins.examples.forEach(example => {
+      this.log(`  ${example}`)
+    })
   }
 }

src/commands/toolbox/index.ts

@@ -1,10 +1,34 @@
 import {Args, Command, Flags} from '@oclif/core'
 
-export default class Core extends Command {
+export default class Toolbox extends Command {
+  static override description = `Solana Ecosystem Tools - Utility commands for common Solana operations
 
-  static override description = 'Various tools for the Solana ecosystem'
+The toolbox commands provide utility functions for common Solana blockchain operations, including SOL management and token operations.
 
-  public async run(): Promise<void> {
+Available subcommands:
+  sol     - SOL management tools (balance, transfer, airdrop)
+  token   - Token management tools (create, update, transfer)
+  rent    - Calculate rent costs for on-chain data storage`
+
+  static override examples = [
+    '$ mplx toolbox sol balance',
+    '$ mplx toolbox sol transfer 1 <recipient_address>',
+    '$ mplx toolbox token create --wizard',
+    '$ mplx toolbox rent 1000',
+  ]
 
+  static override flags = {
+    help: Flags.help({char: 'h'}),
+  }
+
+  public async run(): Promise<void> {
+    const {args, flags} = await this.parse(Toolbox)
+
+    // Show help by default
+    this.log(Toolbox.description)
+    this.log('\nExamples:')
+    Toolbox.examples.forEach(example => {
+      this.log(`  ${example}`)
+    })
   }
 }