Update README.md #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorter command Tested on ubuntu 16.04
davidak
suggested changes
Nov 17, 2017
There was a problem hiding this comment.
Removing --no-check-certificate could lead to problems, when users don't have the right root certificates installed. You can add -k to achieve it with curl.
Tell users to curl to bash is problematic, since they often don't check what they execute. Replacing the link with shortened URL makes it worse. I suggest leave it as is. Using curl instead of wget is fine since it is installed on more systems by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorter command
Tested on ubuntu 16.04