Fix #985 by accepting both str and bytes as arg for json.loads() #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylen384
force-pushed
the
decode
branch
3 times, most recently
from
f89aa1c to
e53ae58
Compare
dpgeorge
reviewed
Apr 10, 2025
unix-ffi/json/json/__init__.py
Outdated
| @@ -413,4 +413,6 @@ def loads( | |||
| kw["parse_int"] = parse_int | |||
| if parse_constant is not None: | |||
| kw["parse_constant"] = parse_constant | |||
| if isinstance(s, bytes): | |||
There was a problem hiding this comment.
CPython also supports bytearray so this could be:
if isinstance(s, (bytes, bytearray)):
Also, please also update the documentation comment for the loads function to mention that s can be str, bytes or bytearray.
There was a problem hiding this comment.
Great, thanks for the quick response!
dpgeorge
approved these changes
Apr 10, 2025
Same as micropython's internal json lib does. Fixes micropython#985. Signed-off-by: Dominik Heidler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as micropython's internal json lib does.