Skip to content

Explicit taskHub parameter for stored procedures #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Explicit taskHub parameter for stored procedures #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
75aebb3
Add taskHubName parameter to all relevant SPs. Add TaskHubMode parame…
Apr 30, 2023
e88327f
Fix issue with failing client queries due to not initialized taskHubN…
May 22, 2023
f913903
Create private set of functions, move task hub name parameter to the …
Jun 3, 2023
040261c
Fix views to work with new and old hub name handling.
Jun 3, 2023
a85a5e8
Cleanup usings and parameter name.
Jun 4, 2023
c5da0e7
Merge branch 'main' into feature/explicit-hub-param
cgillum Sep 23, 2023
522d001
Merge branch 'feature/explicit-hub-param' of https://github.com/micha…
Dec 14, 2023
d9462bc
Merge with 1.2.2
Dec 31, 2023
046251b
Allow ENV set connection string to be used with tests.
Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DurableTask.SqlServer.AzureFunctions/SqlDurabilityOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SqlDurabilityOptions
public string ConnectionStringName { get; set; } = "SQLDB_Connection";

[JsonProperty("taskHubName")]
public string TaskHubName { get; set; } = "default";
public string TaskHubName { get; set; } = SqlOrchestrationServiceSettings.DefaultTaskHubName;

[JsonProperty("taskEventLockTimeout")]
public TimeSpan TaskEventLockTimeout { get; set; } = TimeSpan.FromMinutes(2);
Expand Down
2 changes: 1 addition & 1 deletion src/DurableTask.SqlServer.AzureFunctions/SqlScaleMonitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class SqlScaleMonitor : IScaleMonitor<SqlScaleMetric>
public SqlScaleMonitor(SqlOrchestrationService service, string taskHubName)
{
this.service = service ?? throw new ArgumentNullException(nameof(service));
this.Descriptor = new ScaleMonitorDescriptor($"DurableTask-SqlServer:{taskHubName ?? "default"}");
this.Descriptor = new ScaleMonitorDescriptor($"DurableTask-SqlServer:{taskHubName ?? SqlOrchestrationServiceSettings.DefaultTaskHubName}");
}

/// <inheritdoc />
Expand Down
3 changes: 3 additions & 0 deletions src/DurableTask.SqlServer/Scripts/drop-schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@
-- Licensed under the MIT License.

-- Functions
DROP FUNCTION IF EXISTS __SchemaNamePlaceholder__._CurrentTaskHub
DROP FUNCTION IF EXISTS __SchemaNamePlaceholder__.CurrentTaskHub
DROP FUNCTION IF EXISTS __SchemaNamePlaceholder__._GetScaleMetric
DROP FUNCTION IF EXISTS __SchemaNamePlaceholder__.GetScaleMetric
DROP FUNCTION IF EXISTS __SchemaNamePlaceholder__._GetScaleRecommendation
DROP FUNCTION IF EXISTS __SchemaNamePlaceholder__.GetScaleRecommendation

-- Views
Expand Down
Loading