Add IPv6 support in NetworkInterface feature #3957
Conversation
adityagesh
force-pushed
the
aditya/ipv6_basic
branch
2 times, most recently
from
69dc31e to
9ba90cd
Compare
lisa/features/ipv6.py
Outdated
| from lisa.feature import Feature | ||
|
|
||
|
|
||
| class IPv6(Feature): |
There was a problem hiding this comment.
Add it to NetworkInterface, instead of a new feature. After that, we can deprecate the use_ipv6 on Azure runbook.
There was a problem hiding this comment.
Can you please review the updated implementation? I am still testing it, just want to make sure the approach is correct.
I couldn't figure out how to add Ipv4/ipv6 in initialize environment.
I also have not yet added Ipv4 as default support for existing platforms other than Azure
| unsupported_os=[BSD, Windows], | ||
| ), | ||
| ) | ||
| def perf_tcp_ipv6_ntttcp_sriov(self, result: TestResult) -> None: |
There was a problem hiding this comment.
Is there a specific reason to add perf test cases for IPv6? The IP version shouldn't have a significant performance impact.
There was a problem hiding this comment.
LISA currently do not have coverage for any IPv6 scenario. Hence, I thought performance is a good place to start with.
I also expect that the perf numbers can be potentially different for ipv4 and ipv6
There was a problem hiding this comment.
I don't think there's a performance concern with IPv6. Instead, you can add a functional test case to verify whether the network can communicate using IPv6.
adityagesh
force-pushed
the
aditya/ipv6_basic
branch
from
9ba90cd to
0ff61e7
Compare
adityagesh
changed the title
adityagesh
force-pushed
the
aditya/ipv6_basic
branch
2 times, most recently
from
b00fb8f to
e35839a
Compare
adityagesh
force-pushed
the
aditya/ipv6_basic
branch
from
e35839a to
dd659fb
Compare
Add IPv6 feature by utilizing the existing use_ipv6 runbook parameter.
IPv6 Features enables IPv6 support in VNet, Subnet and enable IPv6 on the nic interface.
The Primary IP of the VM continues to be IPv4, hence no change is required in host that is running LISA. The communication between the VMs uses IPv6.