Backporting safe index update from tip #41
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmjaffe37 was this backported to jdk21u upstream? I assume this Is this fixing a customer issue? |
|
@karianna, I am opening a few PRs that address some ongoing CodeQL/s360 issues. I asked the JVM engineers about the process to potentially upstream these changes, and it seems that the first step is to open PRs for internal review (I am pretty sure that this PR will never be merged here in our fork). That said, I found out recently that backports need to flow backward from tip, so it might be a while before it gets to jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparisons between types of different widths in a loop condition can cause the loop to behave unexpectedly. Here, there could potentially be an infinite loop (if cp_len > 65535)
Link to update in tip: https://github.com/openjdk/jdk/blob/431f46724658b703e995e518cb7a2149c50d6a9d/src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp#L288C2-L299C27