-
Notifications
You must be signed in to change notification settings - Fork 132
kmsg: Log the raw buffer if we fail to parse #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances logging for failed kmsg parses by capturing and displaying the raw buffer on errors, helping diagnose unknown parse failures.
- Extended
InvalidKmsgEntry
error to include the raw byte slice. - Changed parse error handling: tests now use
unwrap
, the tracing task unwraps, and the diagnostic tool matches on the parse result to log failures. - Updated test and runtime code to log or panic on invalid kmsg entries.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs | Switched ? to unwrap on kmsg parse to panic/abort. |
vmm_tests/vmm_tests/tests/tests/multiarch.rs | Switched ? to unwrap on kmsg parse to panic/abort. |
support/kmsg/src/lib.rs | Changed InvalidKmsgEntry to carry the raw buffer. |
petri/src/tracing.rs | Unwrapped kmsg parse in logging task, causing panic. |
openhcl/ohcldiag-dev/src/main.rs | Matched parse result to print invalid entries. |
Comments suppressed due to low confidence (1)
support/kmsg/src/lib.rs:73
- [nitpick] Consider adding a doc comment to
InvalidKmsgEntry
explaining that it carries the raw buffer for debugging, and how it will be formatted in the error message.
pub struct InvalidKmsgEntry<'a>(&'a [u8]);
tjones60
approved these changes
Jul 16, 2025
chris-oo
approved these changes
Jul 16, 2025
smalis-msft
added a commit
to smalis-msft/openvmm
that referenced
this pull request
Jul 16, 2025
We've seen a crash here in the wild, but haven't yet figured out what exactly is failing to parse. Add some more logging so we can hopefully get this if it happens again.
smalis-msft
added a commit
that referenced
this pull request
Jul 16, 2025
Backported in #1709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a crash here in the wild, but haven't yet figured out what exactly is failing to parse. Add some more logging so we can hopefully get this if it happens again.