chore(chromium): pass auto attach filter for iframes #36784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"8 flaky46499 passed, 816 skipped Merge workflow run. |
dgozman
reviewed
Jul 25, 2025
| filter: [ | ||
| { type: 'iframe' }, | ||
| { type: 'worker' }, | ||
| { type: 'service_worker', exclude: !process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS } |
There was a problem hiding this comment.
I think we never want service workers under a page, we get them through setAutoAttach on the browser target.
There was a problem hiding this comment.
The service worker tests fail without this setting, so apparently we rely on the short period when the sw target is enabled.
There was a problem hiding this comment.
If we don't auto-attach to sw in the page, there Network.requestWillBeSent event is missing for the service worker main resource. Notably it is missing in the top level session, not in the page session.
{"method":"Network.requestWillBeSent","params":{"requestId":"B66BDCC8DEB22DC41E120AA63F9610D6","loaderId":"","documentURL":"http://localhost:8907/serviceworkers/fetch/sw.js","request":{"url":"http://localhost:8907/serviceworkers/fetch/sw.js","method":"GET","headers":{"Accept":"*/*","Service-Worker":"script"},"initialPriority":"VeryLow","referrerPolicy":"strict-origin-when-cross-origin"},"timestamp":787594.978643,"wallTime":1753466030.385725,"initiator":{"type":"other","url":"http://localhost:8907/serviceworkers/fetch/sw.html"},"redirectHasExtraInfo":false,"type":"Script","hasUserGesture":false},"sessionId":"45C9C821DA0B480516D191C866250105"}
| flatten: true, | ||
| filter: [ | ||
| { type: 'worker' }, | ||
| { type: 'service_worker', exclude: !process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS } |
There was a problem hiding this comment.
Same here, we only care about workers.
dgozman
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering has been available in Chromium since https://source.chromium.org/chromium/chromium/src/+/c50f73d494d21482bf2cbefa430ce75fc2ad1963. Pass the filter to avoid having to send
Target.detachFromTargetwhich is problematic if we connect to a page via debugger extension API which will throw on attempt to detach e.g. from a service worker.