-
Notifications
You must be signed in to change notification settings - Fork 130
Adding box pragma support to QASM compiler #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
idavis
wants to merge
10
commits into
main
Choose a base branch
from
iadavis/box-pragma
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
e17c0d1
to
59f3de6
Compare
swernli
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a few minor comments. On the naming front, assuming we either ignore the syntax highlighting quirk or fix it, I think keeping the naming used in here (qdk.box.open
) is good.
orpuente-MS
reviewed
Jul 2, 2025
orpuente-MS
reviewed
Jul 2, 2025
orpuente-MS
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
boxed expressions
and pragmas for them when integrating with the Q# compiler.When working in OpenQASM with the QDK, we can now use pragmas to denote parameterless void functions to call at the beginning and/or end of boxed expressions. They can additionally leverage simulatable intrinsic functions which will flow through to code generation.