Skip to content

Conversation

heyitsaamir
Copy link
Collaborator

@heyitsaamir heyitsaamir commented Sep 8, 2025

Minor convenience to auto-load environment params for AI models instad of everyone having to supply it manually

PR Dependency Tree

This tree was auto-generated by Charcoal

@Copilot Copilot AI review requested due to automatic review settings September 8, 2025 22:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request simplifies OpenAI model initialization by automatically loading configuration parameters from environment variables instead of requiring manual specification. This reduces boilerplate code in test files and improves developer experience.

  • Adds auto-loading of OpenAI configuration from environment variables in the base model
  • Removes manual environment variable handling from test files
  • Simplifies model instantiation to use default parameters when available

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/openai/src/microsoft/teams/openai/common.py Adds auto-loading logic for OpenAI parameters from environment variables
tests/mcp-client/src/main.py Removes manual environment handling, simplifies model instantiation
tests/ai-test/src/main.py Removes manual environment handling, simplifies model instantiation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@heyitsaamir heyitsaamir merged commit e8febc9 into main Sep 10, 2025
6 checks passed
@heyitsaamir heyitsaamir deleted the aamirj/autoloadaiprams branch September 10, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants