-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Update to Unicode 17.0.0 #19334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to Unicode 17.0.0 #19334
Conversation
@lhecker i have no idea how to validate this |
From the Unicode 17.0.0 release
That last section is titled,
Do we need to worry about CGJ? |
Well @lhecker the breaking rules have changed enough that even regenerating the tests from unicode 17 results in hundreds of failures :) |
First off, they added tests for grapheme breaking around |
…n-comment-out some of the illegal forms Leonard mentioned
They introduced a bunch of weird phrases like |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (16)
These words are not needed and should be removedCANDRABINDU Ccc ESFCIB foob fuzzyfinder lstrcmpi oob REPHTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:microsoft/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.25/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/17599128086/attempts/1' &&
git commit -m 'Update check-spelling metadata' Forbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: In English, duplicated words are generally mistakesThere are a few exceptions (e.g. "that that").
Errors and Warnings ❌ (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
No description provided.