Do not create SourceFiles for non-existent files #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents the creation of SourceFiles for files that do not exist by adding an existence check before proceeding with file processing. Key changes include:
- Returning nil instead of a SourceFile in both internal/testutil/harnessutil/harnessutil.go and internal/compiler/host.go when the file isn't found.
- Updating baseline test files by removing redundant or extraneous marker lines.
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/conformance/parserRealSource10.js.diff | Adjusted skipped-lines markers and removed an extra marker. |
| testdata/baselines/reference/submodule/conformance/parserRealSource10.js | Removed an unwanted marker line. |
| testdata/baselines/reference/submodule/conformance/parserRealSource1.js.diff | Removed baseline markers and updated skipped-lines counts. |
| testdata/baselines/reference/submodule/conformance/parserRealSource1.js | Removed an unwanted marker line. |
| testdata/baselines/reference/submodule/compiler/selfReferencingFile2.js.diff | Removed duplicated marker line. |
| testdata/baselines/reference/submodule/compiler/selfReferencingFile2.js | Removed duplicated marker line. |
| testdata/baselines/reference/submodule/compiler/moduleAugmentationDuringSyntheticDefaultCheck.js.diff | Removed an unnecessary reference comment and marker. |
| testdata/baselines/reference/submodule/compiler/moduleAugmentationDuringSyntheticDefaultCheck.js | Removed an unnecessary marker line. |
| testdata/baselines/reference/submodule/compiler/invalidTripleSlashReference.js.diff | Removed test lines associated with non-existent references. |
| testdata/baselines/reference/submodule/compiler/invalidTripleSlashReference.js | Removed test lines associated with non-existent references. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans7.js.diff | Adjusted reference comment and removed redundant marker. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans7.js | Removed redundant marker line. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans6.js.diff | Adjusted reference comment and removed redundant marker. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans6.js | Removed redundant marker line. |
| testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference2.js.diff | Removed extraneous marker lines from reference tests. |
| testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference2.js | Removed extraneous marker lines from reference tests. |
| testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference.js.diff | Removed extraneous marker lines from reference tests. |
| testdata/baselines/reference/submodule/compiler/declarationEmitInvalidReference.js | Removed extraneous marker lines from reference tests. |
| internal/testutil/harnessutil/harnessutil.go | Added a file existence check to avoid creating a SourceFile for non-existent files. |
| internal/compiler/host.go | Added a file existence check to avoid creating a SourceFile for non-existent files. |
sheetalkamat
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
I had done this change in #1078 where some of my changes werent working properly because of this
sheetalkamat
approved these changes
Jun 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
sheetalkamat
approved these changes
Jun 10, 2025
|
CI race failure is #1151. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while working on another PR. We were treating all not-found files as empty.
Perhaps this is just papering over some places we don't precheck that a file exists?No, Strada hadgetSourceFile(...): SourceFile | undefined.