Skip to content

Enable CG trigger on insiders branch #13809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

Enable CG trigger on insiders branch #13809

merged 2 commits into from
Aug 4, 2025

Conversation

@bobbrow
Copy link
Member

@bobbrow bobbrow commented Aug 4, 2025

No description provided.

@bobbrow bobbrow requested a review from a team as a code owner August 4, 2025 16:36
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Aug 4, 2025
sean-mcmanus
sean-mcmanus requested changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this fix? Is this the "non-production" branch issue? The bug I was seeing was with the "release" branch. Won't this cause the insiders branch to have the same bug? Isn't the correct fix to remove the "release" branch or is there some other fix pending?

@bobbrow
Copy link
Member Author

bobbrow commented Aug 4, 2025

What does this fix? Is this the "non-production" branch issue? The bug I was seeing was with the "release" branch. Won't this cause the insiders branch to have the same bug? Isn't the correct fix to remove the "release" branch or is there some other fix pending?

This doesn't fix the problem we have with release showing as non-prod, but it allows me to disable the override in the pipeline triggers and have the yaml file be the source of truth instead.

@bobbrow bobbrow merged commit b65fc9f into main Aug 4, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Aug 4, 2025
@bobbrow bobbrow deleted the bobbrow/cg branch August 4, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

cpptools
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobbrow @sean-mcmanus