Skip to content

The windows crate's "std" feature should enable dependent "std" features #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,8 @@ jobs:
run: cargo test -p test_win32_arrays --target ${{ matrix.target }}
- name: Test test_window_long
run: cargo test -p test_window_long --target ${{ matrix.target }}
- name: Test test_windows_std
run: cargo test -p test_windows_std --target ${{ matrix.target }}
- name: Test test_winrt
run: cargo test -p test_winrt --target ${{ matrix.target }}
- name: Test tool_bindgen
Expand All @@ -363,10 +365,10 @@ jobs:
run: cargo test -p tool_test_all --target ${{ matrix.target }}
- name: Test tool_workspace
run: cargo test -p tool_workspace --target ${{ matrix.target }}
- name: Test tool_yml
run: cargo test -p tool_yml --target ${{ matrix.target }}
- name: Clean
run: cargo clean
- name: Test tool_yml
run: cargo test -p tool_yml --target ${{ matrix.target }}
- name: Test windows
run: cargo test -p windows --target ${{ matrix.target }}
- name: Test windows-bindgen
Expand Down
2 changes: 1 addition & 1 deletion crates/libs/collections/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ windows-strings = { workspace = true }

[features]
default = ["std"]
std = []
std = ["windows-core/std"]

[lints]
workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/libs/future/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ windows-result = { workspace = true }

[features]
default = ["std"]
std = []
std = ["windows-core/std"]

[lints]
workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/libs/numerics/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ windows-link = { workspace = true }

[features]
default = ["std"]
std = []
std = ["windows-core/std"]

[lints]
workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/libs/windows/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ rustdoc-args = ["--cfg", "docsrs"]
[features]
default = ["std"]
docs = []
std = ["windows-core/std"]
std = ["windows-collections/std", "windows-core/std", "windows-future/std", "windows-numerics/std"]
# generated features
AI = ["Foundation"]
AI_MachineLearning = ["AI"]
Expand Down
17 changes: 17 additions & 0 deletions crates/tests/libs/windows_std/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
[package]
name = "test_windows_std"
version = "0.0.0"
edition = "2021"
publish = false

[lib]
doc = false
doctest = false

[dependencies]
windows = { workspace = true, features = ["std"] }
# the inclusion of "std" in `windows` should enable it for the following dependencies
windows-collections = { workspace = true }
windows-core = { workspace = true }
windows-future = { workspace = true }
windows-numerics = { workspace = true }
1 change: 1 addition & 0 deletions crates/tests/libs/windows_std/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

19 changes: 19 additions & 0 deletions crates/tests/libs/windows_std/tests/test.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#[test]
fn collections() {
_ = windows_collections::IIterable::<i32>::from(vec![1, 2, 3]);
}

#[test]
fn core() {
_ = windows_core::Event::<windows_core::IUnknown>::new();
}

#[test]
fn future() {
windows_future::IAsyncAction::ready(Ok(()));
}

#[test]
fn numerics() {
windows_numerics::Vector2::zero().length();
}