Skip to content

patch for multiple addresses with unquoted display parts #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch for multiple addresses with unquoted display parts #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tmail/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def self.special_quote_address(str) #:nodoc:
# around the display name when the display name contains a '@'
# like '[email protected] <[email protected]>'
# Just quotes it to: '"[email protected]" <[email protected]>'
when str =~ /\A([^"].+@.+[^"])\s(<.*?>)\Z/
when str =~ /\A([^"][^<]+@[^>]+[^"])\s(<.*?>)\Z/
return "\"#{$1}\" #{$2}"
# This handles cases where 'Mikel A. <[email protected]>' which is a trailing
# full stop before the address section. Just quotes it to
Expand Down
11 changes: 11 additions & 0 deletions test/test_header.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,17 @@ def test_ATTRS
:routes => [],
:spec => '[email protected]'}]
}

validate_case 'Mikel <[email protected]>, another Mikel <[email protected]>',
false,
'Mikel <[email protected]>, another Mikel <[email protected]>',
[],
[{ :phrase => 'Mikel',
:routes => [],
:spec => '[email protected]' },
{ :phrase => 'another Mikel',
:routes => [],
:spec => '[email protected]' }]
end
end

Expand Down