allow using a wrapped net.TCPConn in NewConn #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the connection passed to
NewConn
has to be a*net.TCPConn
, even though the function allows for anet.Conn
to be passed. This is becauseNewConn
performs a type assertion:tcp/rawconn.go
Lines 99 to 112 in 803a9b4
It would be nice if it was possible to pass a wrapped
*net.TCPConn
toNewConn
. This should be a problem, as the only function actually needed isSyscallConn()
. By doing an interface assertion using an interface only fulfilled by anet.TCPConn
, we can even make sure that we don't accidentally use this package with a connection that's not a TCP connection.