feat(deploy/helm): add value option to override release namespace #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TanguyBaudrin , sorry, are you still working/trying to merge this feature into the Helm chart? Best regards, |
Well, on my side I fixed it for my personal usage of the chart. But if this can be merged so everyone will be able to easily override the namespace it could be great ;) |
|
Hello, Understood, thanks for the feedback! Well, in the end I created this one #395 with an associated issue because I had to modify a few things from this PR and was not sure if you would mind me pushing to this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually there's a limitation when using subcharts in helm, the namespace can't be overridden when calling the subchart (see: helm/helm#5358).
In my case I want to add a dependency on a global chart that will deploy the Kubernetes-replicator chart.
But the actually management of Kubernetes replicator namespace doesn't allow me to define another namespace than the one defined in the release of the main chart.
That's why I propose with this PR to implement a "namespaceOverride" value that can be set if someone (like me) wants to use another value than the helm release namespace.