Skip to content
This repository was archived by the owner on Feb 2, 2022. It is now read-only.

Conversation

jakobmygind
Copy link

Not the prettiest string manipulation, but it seems to work with struct and final class

Copy link

@dominik-hadl dominik-hadl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, this will be a great addition!
There's just a few things that need to be fixed before we can merge this :)

  1. Remove @objc from declarations unless absolutely necessary (ie. for performSelector or timers..)
  2. Remove or fix commented out code. There's also no fixmes/todos so it will just get forgotten in the future and it looks bad in the code.
  3. Update travis to compile properly for Swift 4
  4. Can you please write a summary of what exactly has been changed and how? The current description and code changes are impossible to understand for anyone who doesn't know the codebase already.

Otherwise can't wait and will merge asap! 🎉

@jakobmygind jakobmygind force-pushed the feature/EmbeddedObjectDeclaration branch from 533d13a to a4b9054 Compare July 7, 2017 15:12
Added comments
@jakobmygind
Copy link
Author

jakobmygind commented Jul 10, 2017

Changes: Instead of throwing an error when locating several declarations within one model, we now first extract the embedded model then recursively extract the remaining occurrences
and prefix the model name with the parent's name plus ".". The model strings are then passed to the model generator one by one, and the results are concatenated.

Jakob Mygind added 2 commits July 11, 2017 16:44
Refactored embedded model parsing to using a new regex
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants