Client Update for Fixing Multiple Sandbox StreamWriter Issue [ART-8] #3617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client Update for Fixing Multiple Sandbox StreamWriter Issue
This issue fixes an issue in which multiple
stdin
StreamWriters cannot be opened to a Sandbox. Previously, only one StreamWriter could be opened to write messages tostdin
. Our new fix, at a high level, more explicitly enforces only one open StreamWriter, assigning auuid
to each writer and adds anactive_writer_id
attribute for sandboxes. Protobuf changes include adding awriter_id
toRuntimeInputMessage
and toSandboxStdinWriteRequest
.The Linear issue contains a Slack Thread for a relevant client problem.
Checklists
Compatibility checklist
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Release checklist
If you intend for this commit to trigger a full release to PyPI, please ensure that the following steps have been taken:
modal_version/__init__.py
) has been updated with the next logical versionChangelog