Skip to content

Display "completions not supported" for resource templates which do not support completions. #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

balajmarius
Copy link
Contributor

@balajmarius balajmarius commented May 30, 2025

Motivation and Context

This adds the functionality requested #458 and a small dark screen fix.

How Has This Been Tested?

Added combobox.test.jsx.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@cliffhall
Copy link
Contributor

cliffhall commented Jun 2, 2025

Hi @balajmarius! Thanks for this. Could you add a screenshot of the implementation?

The screenshot in #458 shows the id field with a dropdown that only displays the message that completions are not supported when you click it. That doesn't seem right. I think that the entire component should be replaced with the message instead. No need to click a dropdown in order to find out that it isn't supported.

@cliffhall cliffhall added the waiting on submitter Waiting for the submitter to provide more info label Jun 2, 2025
@balajmarius
Copy link
Contributor Author

Hi @cliffhall,

Thanks for the feedback!

You're right, my current implementation places the message inside the dropdown component. I'll update the PR in the next few days to replace the entire component with the message instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on submitter Waiting for the submitter to provide more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants