Skip to content

Fix: Remove addition slash for check proxy health #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sebastian93921
Copy link

@sebastian93921 sebastian93921 commented Jun 10, 2025

Remove the additional slash / at the end of the proxy base URL

Motivation and Context

During an MCP course, I found out that if I type the inspector proxy address base URL as follows, https://s172-29-9-71p6277.lab-aws-production.deeplearning.ai/, it will cause an error
image

Turns out if the user types a slash / at the end of the address, which will cause a double slash //, it makes the error occur.

How Has This Been Tested?

Add a slash and without a slash

Breaking Changes

Will users need to update their code or configurations? No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@sebastian93921 sebastian93921 changed the title Sebastian/patch remove addition slash Fix: remove addition slash Jun 10, 2025
@sebastian93921 sebastian93921 changed the title Fix: remove addition slash Fix: remove addition slash for check proxy health Jun 10, 2025
@sebastian93921 sebastian93921 changed the title Fix: remove addition slash for check proxy health Fix: Remove addition slash for check proxy health Jun 10, 2025
@olaservo
Copy link
Member

Hi, could you grab the latest from main? We had to push a few bug fixes through including a security update, which looks like it caused some conflicts in your PR. Thanks!

@sebastian93921
Copy link
Author

Hi @olaservo
I have moved the regex replaces / logic to the getMCPProxyAddress function, which caters to other API calling functions and solves the merge issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants