Skip to content

Feat/prompt layout #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

evalstate
Copy link
Contributor

Make the Prompt and Tool listing layout consistent.

Motivation and Context

Make navigation easier.

How Has This Been Tested?

~
image

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@olaservo
Copy link
Member

OK, I figured out what changed that broke the mocks:

jest-environment-jsdom

Version Change: 29.7.0 → 30.0.0

Error: TypeError: Cannot redefine property: location

The test fails because jest-environment-jsdom version 30.0.0 introduced a breaking change where window.location can no longer be redefined using Object.defineProperty() in the same way that worked in version 29.7.0.

The specific failing code in AuthDebugger.test.tsx (line 87):

Object.defineProperty(window, "location", {
  value: {
    origin: "http://localhost:3000",
  },
});

Want to note this is at least one of the PRs in case there was a reason why it was being set up this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants