-
Notifications
You must be signed in to change notification settings - Fork 299
add user hover cards and ext. link warnings #3443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is awesome, hope this gets merged soon! |
Lots of great stuff in this pull request, would you be able to split it up into separate PRs though? |
Could take a while. If absolutely necessary, sure. |
Appreciate the contribution! A large PR like this with many unrelated features will likely not get merged, however, since the design and code review it would take is likely unjustifiable. If you'd like to reopen any of these features in the future as individual PRs, please do keep them small in scope and be prepared for both design and code reviews that may require significant changes. |
this is my first PR, so i probably made a few mistakes. here's what i've done:
add user hover cards to relevant components
these are meant to be as unintrusive as possible and remove when the user scrolls. it takes 150ms for it to start loading the assets required for it on hover of a user-link.
add external link warnings
this checks if the user is visiting a link that is outside of the modrinth scope and gives them a warning if they are.