-
Notifications
You must be signed in to change notification settings - Fork 58
add more map review checks #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add more map review checks #370
Conversation
bee3bc6
to
71657ad
Compare
71657ad
to
96f814c
Compare
96f814c
to
4ed6f43
Compare
For more in-depth information on map porting, please see the [map porting](../map_porting) and [zoning](../map_zoning) guides. | ||
|
||
First check: | ||
- [ ] The map has been in public testing for at least 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of just something for us to think about, but I feel like we need a way to see how much each track was actually played in the testing period. I've reviewed maps that had few if any completions so I couldn't actually be sure how much it was tested. Maybe this will be better now that there's more people able to play.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's Tom's idea to keep maps in public testing for at least 7 days, but admins can bypass this. I'm adding this box mainly because I've seen some maps get fast-tracked and approved within a day of entering public testing, one instance (I think) within an hour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 7 day thing has been planned for years, before I was even involved with the project. Honestly it's pretty skeptical of its usefulness. As rio said it doesn't guarantee people actually complete the map. Requiring completions doesn't sound particularly helpful either though, most players aren't providing feedback. I guess it's good to confirm that it's even beatable, but doesn't guarantee it's been tested significantly beyond that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There have been a few maps that have been approved but had problems that needed addressing, which in a lot of those cases we would definitely have found the issues had the map been out in public testing for 7 days.
So I think we should keep that limit
@jason-e please merge if you are happy with it, |
No description provided.