SafeStream: don't fail if receiver can't accept transfer #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caffeinum
commented
Sep 6, 2022
| } | ||
|
|
||
| // failed transfers are accumulated and sent to fallback | ||
| _transfer(_fallback, address(this).balance); |
There was a problem hiding this comment.
instead of counting values, just transfer everything that's left out
caffeinum
commented
Sep 6, 2022
contracts/SafeStream.sol
Outdated
| return callStatus; | ||
| } | ||
|
|
||
| function setHardCap(uint c) external { |
There was a problem hiding this comment.
this is an extra protection against malicious receivers that try to drain all gas from the sender
sender might be OpenSea royalty system, for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not ready to merge, just FYI to discuss the implementation