Skip to content

Conversation

mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Oct 2, 2025

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit marked this pull request as ready for review October 2, 2025 13:31
@mabaasit mabaasit requested a review from a team as a code owner October 2, 2025 13:31
@mabaasit mabaasit requested review from ivandevp and Copilot October 2, 2025 13:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the index creation UI by adding more descriptive help text for the text index type. The change updates the display text from "text" to "text (full text search)" to provide better clarity for users about what this index type does.

  • Updated index type display text to be more descriptive
  • Updated related test files to use the new text format
  • Maintained backward compatibility in the underlying index creation logic

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/compass-indexes/src/modules/create-index.tsx Updated field type mapping to handle new descriptive text format
packages/compass-indexes/src/modules/create-index.spec.ts Updated test to use new text index display format
packages/compass-indexes/src/components/create-index-fields.tsx Updated INDEX_TYPES array with descriptive text and fixed dependency array
packages/compass-e2e-tests/helpers/commands/create-index.ts Updated E2E test mapping for new text index display format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +543 to +545
if (type === 'text (full text search)') {
return 'text';
}
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original condition if (type === 'text' || type === '2dsphere') on line 546 still includes the old 'text' check, but this code path is now unreachable since 'text (full text search)' is handled above. The condition should be updated to only check for '2dsphere' or the old 'text' condition should be removed entirely.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant