fix: improve node-fetch compatibility in error cases MONGOSH-2443 #224
+151
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node-fetch` currently does not return a body that is a web/standard `ReadableStream`, which is what openid-client expects. Since it only makes use of this in error cases, no additional cases are broken, but the error message is highly unhelpful in these cases. Unfortunately, it is not trivial to resolve this without fully wrapping the `node-fetch`, so this provides a limited compatibility layer rather than a full-featured one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-fetchcurrently does not return a body that is a web/standardReadableStream, which is what openid-client expects. Since it only makes use of this in error cases, no additional cases are broken, but the error message is highly unhelpful in these cases.Unfortunately, it is not trivial to resolve this without fully wrapping the
node-fetch, so this provides a limited compatibility layer rather than a full-featured one. (Note – I'm opening the PR with this approach but I'd be up for changing this if somebody feels strongly that we should put in the effort to provide a full layer aroundResponse. We can't "just" replace.bodyonly because node-fetch's.text()and.json()methods expect it to be a Node.js stream.)