Improve error handling on unsupported hybrid queries #3404
+49
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hybrid belongs-to-many relationships are not supported for query constraints. However, the support check was done downstream of a bunch of Eloquent stuff, resulting in the user getting an exception that didn't tell them anything about the usage being unsupported. This moves that check further up the chain so that the user is alerted to the lack of support before we do anything else.
GromNaN
requested changes
Jun 18, 2025
| return; | ||
| } | ||
|
|
||
| throw new Exception(class_basename($relation) . ' is not supported for hybrid query constraints.'); |
There was a problem hiding this comment.
You can be more specific, this is a logic exception (developer fault).
Suggested change
| throw new Exception(class_basename($relation) . ' is not supported for hybrid query constraints.'); | |
| throw new \LogicException(class_basename($relation) . ' is not supported for hybrid query constraints.'); |
| * | ||
| * @throws Exception | ||
| */ | ||
| public function assertHybridRelationSupported(Relation $relation): void |
There was a problem hiding this comment.
If this method don't need to be public, make it private so that we don't have to maintain backward compatibility on it.
Suggested change
| public function assertHybridRelationSupported(Relation $relation): void | |
| private function assertHybridRelationSupported(Relation $relation): void |
In PHPLIB we enforce private methods to be at after the public ones, I think that would be a good idea for this method to move it at the end.
There was a problem hiding this comment.
Agree, I made it public cause I thought the other usage was outside of the class (it's not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hybrid belongs-to-many relationships are not supported for query constraints. However, the support check was done downstream of a bunch of Eloquent stuff, resulting in the user getting an exception that didn't tell them anything about the usage being unsupported.
This moves that check further up the chain so that the user is alerted to the lack of support before we do anything else.
Checklist