Support arrays/collections mapping

src/integrationTest/java/com/mongodb/hibernate/IdentifierIntegrationTests.java

@@ -87,6 +87,11 @@ class IdentifierIntegrationTests implements SessionFactoryScopeAware {
 
     private SessionFactoryScope sessionFactoryScope;
 
+    @Override
+    public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
+        this.sessionFactoryScope = sessionFactoryScope;
+    }
+
     @Test
     void withSpaceAndDotAndMixedCase() {
         var item = new WithSpaceAndDotAndMixedCase();
@@ -197,11 +202,6 @@ void endingWithRightSquareBracket() {
         sessionFactoryScope.inTransaction(session -> session.find(EndingWithRightSquareBracket.class, item.id));
     }
 
-    @Override
-    public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
-        this.sessionFactoryScope = sessionFactoryScope;
-    }
-
     @Entity
     @Table(name = WithSpaceAndDotAndMixedCase.COLLECTION_NAME)
     static class WithSpaceAndDotAndMixedCase {

src/integrationTest/java/com/mongodb/hibernate/MongoTestAssertions.java

@@ -40,11 +40,11 @@ public static void assertUsingRecursiveComparison(
             @Nullable Object actual,
             BiConsumer<RecursiveComparisonAssert<?>, Object> assertion) {
         assertion.accept(
-                assertThat(expected)
+                assertThat(actual)
                         .usingRecursiveComparison()
                         .usingOverriddenEquals()
                         .withStrictTypeChecking(),
-                actual);
+                expected);
     }
 
     /**

src/integrationTest/java/com/mongodb/hibernate/id/ObjectIdAsIdIntegrationTests.java

@@ -53,6 +53,11 @@ class ObjectIdAsIdIntegrationTests implements SessionFactoryScopeAware {
 
     private SessionFactoryScope sessionFactoryScope;
 
+    @Override
+    public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
+        this.sessionFactoryScope = sessionFactoryScope;
+    }
+
     @Test
     void insert() {
         var item = new Item();
@@ -70,11 +75,6 @@ void findById() {
         assertEquals(item.id, loadedItem.id);
     }
 
-    @Override
-    public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
-        this.sessionFactoryScope = sessionFactoryScope;
-    }
-
     @Nested
     class Generated {
         @Test

src/integrationTest/java/com/mongodb/hibernate/query/select/AbstractSelectionQueryIntegrationTests.java

@@ -42,14 +42,6 @@ abstract class AbstractSelectionQueryIntegrationTests implements SessionFactoryS
 
     private TestCommandListener testCommandListener;
 
-    SessionFactoryScope getSessionFactoryScope() {
-        return sessionFactoryScope;
-    }
-
-    TestCommandListener getTestCommandListener() {
-        return testCommandListener;
-    }
-
     @Override
     public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
         this.sessionFactoryScope = sessionFactoryScope;
@@ -60,6 +52,14 @@ public void injectServiceRegistryScope(ServiceRegistryScope serviceRegistryScope
         this.testCommandListener = serviceRegistryScope.getRegistry().requireService(TestCommandListener.class);
     }
 
+    SessionFactoryScope getSessionFactoryScope() {
+        return sessionFactoryScope;
+    }
+
+    TestCommandListener getTestCommandListener() {
+        return testCommandListener;
+    }
+
     <T> void assertSelectionQuery(
             String hql,
             Class<T> resultType,

src/integrationTest/java/com/mongodb/hibernate/query/select/SimpleSelectQueryIntegrationTests.java

@@ -39,6 +39,11 @@ class SimpleSelectQueryIntegrationTests extends AbstractSelectionQueryIntegratio
 
     @Nested
     class QueryTests {
+        @BeforeEach
+        void beforeEach() {
+            getSessionFactoryScope().inTransaction(session -> testingContacts.forEach(session::persist));
+            getTestCommandListener().clear();
+        }
 
         private static final List<Contact> testingContacts = List.of(
                 new Contact(1, "Bob", 18, Country.USA),
@@ -56,12 +61,6 @@ private static List<Contact> getTestingContacts(int... ids) {
                     .toList();
         }
 
-        @BeforeEach
-        void beforeEach() {
-            getSessionFactoryScope().inTransaction(session -> testingContacts.forEach(session::persist));
-            getTestCommandListener().clear();
-        }
-
         @ParameterizedTest
         @ValueSource(booleans = {true, false})
         void testComparisonByEq(boolean fieldAsLhs) {

src/integrationTest/java/com/mongodb/hibernate/query/select/SortingSelectQueryIntegrationTests.java

@@ -38,6 +38,11 @@
 
 @DomainModel(annotatedClasses = Book.class)
 class SortingSelectQueryIntegrationTests extends AbstractSelectionQueryIntegrationTests {
+    @BeforeEach
+    void beforeEach() {
+        getSessionFactoryScope().inTransaction(session -> testingBooks.forEach(session::persist));
+        getTestCommandListener().clear();
+    }
 
     private static final List<Book> testingBooks = List.of(
             new Book(1, "War and Peace", 1869, true),
@@ -55,12 +60,6 @@ private static List<Book> getBooksByIds(int... ids) {
                 .toList();
     }
 
-    @BeforeEach
-    void beforeEach() {
-        getSessionFactoryScope().inTransaction(session -> testingBooks.forEach(session::persist));
-        getTestCommandListener().clear();
-    }
-
     @ParameterizedTest
     @ValueSource(strings = {"ASC", "DESC"})
     void testOrderBySingleFieldWithoutTies(String sortDirection) {

src/integrationTest/java/com/mongodb/hibernate/type/ObjectIdIntegrationTests.java

@@ -58,6 +58,11 @@ class ObjectIdIntegrationTests implements SessionFactoryScopeAware {
 
     private SessionFactoryScope sessionFactoryScope;
 
+    @Override
+    public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
+        this.sessionFactoryScope = sessionFactoryScope;
+    }
+
     @Test
     void insert() {
         var item = new Item();
@@ -94,11 +99,6 @@ void findById() {
         assertEq(item, loadedItem);
     }
 
-    @Override
-    public void injectSessionFactoryScope(SessionFactoryScope sessionFactoryScope) {
-        this.sessionFactoryScope = sessionFactoryScope;
-    }
-
     @Nested
     class Generated {
         @Test

src/main/java/com/mongodb/hibernate/dialect/MongoAggregateSupport.java

@@ -19,6 +19,7 @@
 import static java.lang.String.format;
 
 import com.mongodb.hibernate.internal.FeatureNotSupportedException;
+import com.mongodb.hibernate.internal.type.MongoArrayJdbcType;
 import com.mongodb.hibernate.internal.type.MongoStructJdbcType;
 import org.hibernate.dialect.aggregate.AggregateSupportImpl;
 import org.hibernate.mapping.AggregateColumn;
@@ -38,10 +39,11 @@ public String aggregateComponentCustomReadExpression(
             AggregateColumn aggregateColumn,
             Column column) {
         var aggregateColumnType = aggregateColumn.getTypeCode();
-        if (aggregateColumnType == MongoStructJdbcType.JDBC_TYPE.getVendorTypeNumber()) {
+        if (aggregateColumnType == MongoStructJdbcType.JDBC_TYPE.getVendorTypeNumber()
+                || aggregateColumnType == MongoArrayJdbcType.HIBERNATE_SQL_TYPE) {
             return format(
-                    "unused from %s.aggregateComponentCustomReadExpression",
-                    MongoAggregateSupport.class.getSimpleName());
+                    "unused from %s.aggregateComponentCustomReadExpression for SQL type code [%d]",
+                    MongoAggregateSupport.class.getSimpleName(), aggregateColumnType);
         }
         throw new FeatureNotSupportedException(format("The SQL type code [%d] is not supported", aggregateColumnType));
     }
@@ -53,17 +55,19 @@ public String aggregateComponentAssignmentExpression(
             AggregateColumn aggregateColumn,
             Column column) {
         var aggregateColumnType = aggregateColumn.getTypeCode();
-        if (aggregateColumnType == MongoStructJdbcType.JDBC_TYPE.getVendorTypeNumber()) {
+        if (aggregateColumnType == MongoStructJdbcType.JDBC_TYPE.getVendorTypeNumber()
+                || aggregateColumnType == MongoArrayJdbcType.HIBERNATE_SQL_TYPE) {
             return format(
-                    "unused from %s.aggregateComponentAssignmentExpression",
-                    MongoAggregateSupport.class.getSimpleName());
+                    "unused from %s.aggregateComponentAssignmentExpression for SQL type code [%d]",
+                    MongoAggregateSupport.class.getSimpleName(), aggregateColumnType);
         }
         throw new FeatureNotSupportedException(format("The SQL type code [%d] is not supported", aggregateColumnType));
     }
 
     @Override
     public boolean requiresAggregateCustomWriteExpressionRenderer(int aggregateSqlTypeCode) {
-        if (aggregateSqlTypeCode == MongoStructJdbcType.JDBC_TYPE.getVendorTypeNumber()) {
+        if (aggregateSqlTypeCode == MongoStructJdbcType.JDBC_TYPE.getVendorTypeNumber()
+                || aggregateSqlTypeCode == MongoArrayJdbcType.HIBERNATE_SQL_TYPE) {
             return false;
         }
         throw new FeatureNotSupportedException(format("The SQL type code [%d] is not supported", aggregateSqlTypeCode));

src/main/java/com/mongodb/hibernate/dialect/MongoDialect.java

@@ -20,7 +20,9 @@
 import static java.lang.String.format;
 
 import com.mongodb.hibernate.internal.translate.MongoTranslatorFactory;
+import com.mongodb.hibernate.internal.type.MongoArrayJdbcType;
 import com.mongodb.hibernate.internal.type.MongoStructJdbcType;
+import com.mongodb.hibernate.internal.type.MqlType;
 import com.mongodb.hibernate.internal.type.ObjectIdJavaType;
 import com.mongodb.hibernate.internal.type.ObjectIdJdbcType;
 import com.mongodb.hibernate.jdbc.MongoConnectionProvider;
@@ -31,6 +33,7 @@
 import org.hibernate.engine.jdbc.dialect.spi.DialectResolutionInfo;
 import org.hibernate.service.ServiceRegistry;
 import org.hibernate.sql.ast.SqlAstTranslatorFactory;
+import org.hibernate.type.descriptor.sql.internal.DdlTypeImpl;
 import org.jspecify.annotations.Nullable;
 
 /**
@@ -91,9 +94,24 @@ public SqlAstTranslatorFactory getSqlAstTranslatorFactory() {
     @Override
     public void contribute(TypeContributions typeContributions, ServiceRegistry serviceRegistry) {
         super.contribute(typeContributions, serviceRegistry);
+        contributeObjectIdType(typeContributions);
+        typeContributions.contributeJdbcTypeConstructor(MongoArrayJdbcType.Constructor.INSTANCE);
+        typeContributions.contributeJdbcType(MongoStructJdbcType.INSTANCE);
+    }
+
+    private void contributeObjectIdType(TypeContributions typeContributions) {
         typeContributions.contributeJavaType(ObjectIdJavaType.INSTANCE);
         typeContributions.contributeJdbcType(ObjectIdJdbcType.INSTANCE);
-        typeContributions.contributeJdbcType(MongoStructJdbcType.INSTANCE);
+        var objectIdTypeCode = MqlType.OBJECT_ID.getVendorTypeNumber();
+        typeContributions
+                .getTypeConfiguration()
+                .getDdlTypeRegistry()
+                .addDescriptorIfAbsent(new DdlTypeImpl(
+                        objectIdTypeCode,
+                        format(
+                                "unused from %s.contributeObjectIdType for SQL type code [%d]",
+                                MongoDialect.class.getSimpleName(), objectIdTypeCode),
+                        this));
     }
 
     @Override
@@ -105,4 +123,9 @@ public void contribute(TypeContributions typeContributions, ServiceRegistry serv
     public AggregateSupport getAggregateSupport() {
         return MongoAggregateSupport.INSTANCE;
     }
+
+    @Override
+    public boolean supportsStandardArrays() {
+        return true;
+    }
 }

src/main/java/com/mongodb/hibernate/internal/MongoAssertions.java

@@ -33,7 +33,7 @@ private MongoAssertions() {}
      */
     public static <T> T assertNotNull(@Nullable T value) throws AssertionError {
         if (value == null) {
-            throw new AssertionError();
+            throw fail();
         }
         return value;
     }
@@ -69,7 +69,7 @@ public static AssertionError fail() throws AssertionError {
      */
     public static void assertNull(@Nullable Object value) throws AssertionError {
         if (value != null) {
-            throw new AssertionError();
+            throw fail();
         }
     }
 
@@ -82,7 +82,7 @@ public static void assertNull(@Nullable Object value) throws AssertionError {
      */
     public static boolean assertTrue(boolean value) throws AssertionError {
         if (!value) {
-            throw new AssertionError();
+            throw fail();
         }
         return true;
     }
@@ -96,8 +96,15 @@ public static boolean assertTrue(boolean value) throws AssertionError {
      */
     public static boolean assertFalse(boolean value) throws AssertionError {
         if (value) {
-            throw new AssertionError();
+            throw fail();
         }
         return false;
     }
+
+    public static <T> T assertInstanceOf(@Nullable Object value, Class<? extends T> type) {
+        if (!type.isInstance(value)) {
+            throw fail();
+        }
+        return type.cast(value);
+    }
 }

src/main/java/com/mongodb/hibernate/internal/cfg/MongoConfigurationBuilder.java

@@ -73,15 +73,13 @@ private static final class ConfigPropertiesParser {
             var jdbcUrl = configurationValues.get(JAKARTA_JDBC_URL);
             if (jdbcUrl == null) {
                 return null;
-            }
-            if (jdbcUrl instanceof String jdbcUrlText) {
+            } else if (jdbcUrl instanceof String jdbcUrlText) {
                 return parseConnectionString(JAKARTA_JDBC_URL, jdbcUrlText);
             } else if (jdbcUrl instanceof ConnectionString jdbcUrlConnectionString) {
                 return jdbcUrlConnectionString;
-            } else {
-                throw MongoConfigurationBuilder.ConfigPropertiesParser.Exceptions.unsupportedType(
-                        JAKARTA_JDBC_URL, jdbcUrl, String.class, ConnectionString.class);
             }
+            throw MongoConfigurationBuilder.ConfigPropertiesParser.Exceptions.unsupportedType(
+                    JAKARTA_JDBC_URL, jdbcUrl, String.class, ConnectionString.class);
         }
 
         private static ConnectionString parseConnectionString(String propertyName, String propertyValue) {

src/main/java/com/mongodb/hibernate/internal/extension/MongoAdditionalMappingContributor.java

@@ -57,6 +57,7 @@ public void contribute(
             InFlightMetadataCollector metadata,
             ResourceStreamLocator resourceStreamLocator,
             MetadataBuildingContext buildingContext) {
+        forbidEmbeddablesWithoutPersistentAttributes(metadata);
         metadata.getEntityBindings().forEach(persistentClass -> {
             forbidDynamicInsert(persistentClass);
             checkColumnNames(persistentClass);
@@ -67,7 +68,8 @@ public void contribute(
 
     private static void forbidDynamicInsert(PersistentClass persistentClass) {
         if (persistentClass.useDynamicInsert()) {
-            throw new FeatureNotSupportedException(format("%s is not supported", DynamicInsert.class.getSimpleName()));
+            throw new FeatureNotSupportedException(
+                    format("%s: %s is not supported", persistentClass, DynamicInsert.class.getSimpleName()));
         }
     }
 
@@ -100,6 +102,15 @@ private static void forbidStructIdentifier(PersistentClass persistentClass) {
         }
     }
 
+    private static void forbidEmbeddablesWithoutPersistentAttributes(InFlightMetadataCollector metadata) {
+        metadata.visitRegisteredComponents(component -> {
+            if (!component.hasAnyInsertableColumns()) {
+                throw new FeatureNotSupportedException(
+                        format("%s: must have at least one persistent attribute", component));
+            }
+        });
+    }
+
     private static void setIdentifierColumnName(PersistentClass persistentClass) {
         var identifier = persistentClass.getIdentifier();
         assertFalse(identifier.hasFormula());

src/main/java/com/mongodb/hibernate/internal/translate/AbstractMqlTranslator.java

@@ -950,6 +950,7 @@ private static boolean isComparingFieldWithValue(ComparisonPredicate comparisonP
     }
 
     private static BsonValue toBsonValue(Object value) {
+        // TODO-HIBERNATE-74 decide if `value` is nullable
         try {
             return ValueConversions.toBsonValue(value);
         } catch (SQLFeatureNotSupportedException e) {