Add round-trip test for time-series with a TTL index #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyam12860
reviewed
Mar 24, 2025
|
|
||
| // GetFCV is like GetFCVErr but panicks instead of returning an error. | ||
| // Avoid this function in new code. | ||
| func GetFCV(s *mongo.Client) string { |
There was a problem hiding this comment.
nit: should we call this GetFCVFatal or similar?
There was a problem hiding this comment.
Nvm this is in use already and renaming requires renaming everything
There was a problem hiding this comment.
I mean, renaming is easy enough with IDEs … I’ll call it GetFCVOrPanic.
shyam12860
reviewed
Mar 24, 2025
| restore, err := getRestoreWithArgs(args...) | ||
| require.NoError(t, err, "restore should run") | ||
| defer restore.Close() | ||
|
|
There was a problem hiding this comment.
Are there any specific checks related to restoration of the TTL index that we should include in this test? Like checking if the index was restored with the right TTL for example
There was a problem hiding this comment.
Doh! Yes, I should add that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a new convenience for skipping a test if the cluster’s FCV isn’t recent enough.