Skip to content

feat(NODE-6991): deprecate remaining types to be removed in v7 #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(NODE-6991): deprecate remaining types to be removed in v7 #4566

wants to merge 2 commits into from
+9 −2

Conversation

durran
Copy link
Member

@durran durran commented Jun 23, 2025 •
edited
Loading

Description

Deprecates ClientMetadata, ClientMetadataOptions, and CancellationToken.

What is changing?

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6991

Release Highlight

ClientMetadata, ClientMetadataOptions, and CancellationToken have been deprecated.

The first 2 will become private in the next major release while CancellationToken will be replaced by AbortSignal.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review June 24, 2025 11:57
@durran durran requested a review from a team as a code owner June 24, 2025 11:57
@durran durran changed the title chore(NODE-6991): deprecate remaining types to be removed in v7 feat(NODE-6991): deprecate remaining types to be removed in v7 Jun 24, 2025
baileympearson
baileympearson requested changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deprecate MongoOptions.metadata as well? That's the place that publicly exposed ClientMetadata.

@baileympearson baileympearson self-assigned this Jun 24, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 24, 2025
@durran @baileympearson
Update src/mongo_types.ts
4703edc 
Co-authored-by: Bailey Pearson <[email protected]>
@durran durran requested a review from baileympearson June 25, 2025 11:21
baileympearson
baileympearson requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment was missed: #4566 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@durran @baileympearson