Non hashable args like fdebug-prefix-map & related #2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borjamunozf
force-pushed
the
feature/donthashdebugprefixargs
branch
from
6b250b9 to
080280a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2409 +/- ##
==========================================
+ Coverage 71.58% 71.60% +0.02%
==========================================
Files 65 65
Lines 36214 36240 +26
==========================================
+ Hits 25923 25949 +26
Misses 10291 10291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sylvestre
force-pushed
the
feature/donthashdebugprefixargs
branch
from
a7122f0 to
bac9935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I realized that compilers arguments/flags for gcc like the mentioned above are being used in the hash_key function. This means that strategies for handling the absolute paths to relatives regarding debug info or in similar fashion that involves passing a dynamic value into the argument depending of the builder origin will create a different hash key.
From my point of view, these kind of arguments should not affect the computer hash key at all:
A naive change could just include a non-hashable list of args that should be skipped or not considered into the hash key.